Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c10d][Doc] Add a flight recorder tutorial #3040

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Sep 6, 2024

Summary:
Recreating pull request #3024 because of bad merges.

Re-add flight recorder tutorial with prior comments addressed

Test Plan:
Ran:

rst2html5 flight_recorder_tutorial.rst flight_recorder_tutorial.html
Also, preview documentation is here: https://docs-preview.pytorch.org/pytorch/tutorials/3040/prototype/flight_recorder_tutorial.html

Reviewers: fduwjj, svekars

Fixes #ISSUE_NUMBER

Description

Checklist

  • [x ] The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • [x ] Only one issue is addressed in this pull request
  • [x ] Labels from the issue that this PR is fixing are added to this pull request
  • [x ] No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Sep 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3040

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1018126 with merge base 129e318 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@c-p-i-o c-p-i-o force-pushed the cpio/flight_recorder_2 branch 2 times, most recently from 3a5c189 to 8022151 Compare September 6, 2024 19:52
@c-p-i-o
Copy link
Contributor Author

c-p-i-o commented Sep 6, 2024

@pytorchbot drci

Summary:
Recreating pull request #3024 because of bad merges.
Re-add flight recorder tutorial with prior comments addressed

Test Plan:
Ran:

rst2html5 flight_recorder_tutorial.rst flight_recorder_tutorial.html

Reviewers: fduwjj, svekars
@c-p-i-o c-p-i-o force-pushed the cpio/flight_recorder_2 branch from 8022151 to ba4d7d6 Compare September 6, 2024 22:02
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure the environment variable is showing as expected. Thanks!

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but otherwise, LGTM!

@c-p-i-o
Copy link
Contributor Author

c-p-i-o commented Sep 9, 2024

Thanks @svekars for the fixes!

Summary:
minor formatting changes.
Summary:
Fix white space.
@c-p-i-o
Copy link
Contributor Author

c-p-i-o commented Sep 9, 2024

@pytorchbot merge

Copy link

pytorch-bot bot commented Sep 9, 2024

Mergebot is not configured for this repository. Please use the merge button provided by GitHub.

@c-p-i-o c-p-i-o merged commit 8a8331e into main Sep 9, 2024
19 checks passed
@svekars svekars deleted the cpio/flight_recorder_2 branch September 9, 2024 21:50
@svekars svekars added the 2.5 PR related to version 2.5 label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.5 PR related to version 2.5 cla signed new tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants