Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBcode->GH] Fix missing kernel guards (#4620) #4743

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Oct 26, 2021

This is an old FBcode=>GH commit which was missed. It's also breaking our the linter of main.


Summary:
Pull Request resolved: #4620

Pull Request resolved: pytorch/nestedtensor#455

Fixes missing kernel guards as identified by D30072495

Reviewed By: jingsh, xush6528

Differential Revision: D31553158

fbshipit-source-id: 80de017ba2ddc52e2a684df9b3eae5de84ed49f4

Summary:
Pull Request resolved: pytorch#4620

Pull Request resolved: pytorch/nestedtensor#455

Fixes missing kernel guards as identified by D30072495

Reviewed By: jingsh, xush6528

Differential Revision: D31553158

fbshipit-source-id: 80de017ba2ddc52e2a684df9b3eae5de84ed49f4
@facebook-github-bot
Copy link

facebook-github-bot commented Oct 26, 2021

💊 CI failures summary and remediations

As of commit 066bc93 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI clang_format curl https://oss-clang-format.s3.us-east-2.amazonaws.com/linux64/clang-format-linux64 -o clang-format
chmod +x clang-format
sudo mv clang-format /opt/clang-format
./.circleci/unittest/linux/scripts/run-clang-format.py -r torchvision/csrc --clang-format-executable /opt/clang-format
🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox merged commit 847ac3d into pytorch:main Oct 26, 2021
@datumbox datumbox deleted the fbsync_missing_commit2 branch October 26, 2021 08:16
@datumbox datumbox mentioned this pull request Oct 26, 2021
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
Summary:
Pull Request resolved: pytorch#4620

Pull Request resolved: pytorch/nestedtensor#455

Fixes missing kernel guards as identified by D30072495

Reviewed By: jingsh, xush6528

Differential Revision: D31553158

fbshipit-source-id: 80de017ba2ddc52e2a684df9b3eae5de84ed49f4

Co-authored-by: Richard Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants