[ROCm][Windows] Fix compile torchvision image for ROCm

[tvukovic-amd]

moved PyInit_image definition to common.cpp since image.cpp is not used

cc @jeffdaily @jithunnair-amd

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8897

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @tvukovic-amd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[jeffdaily]

@tvukovic-amd I tried building your PR branch on ubuntu and got the error:

/var/lib/jenkins/vision/torchvision/csrc/io/image/image_hip.cpp:35:41: error: ‘decode_jpegs_hip’ was not declared in this scope; did you mean ‘decode_jpegs_cuda’?
   35 |         .op("image::decode_jpegs_hip", &decode_jpegs_hip)                                                                          |                                         ^~~~~~~~~~~~~~~~
      |                                         decode_jpegs_cuda

[jeffdaily]

Build for ROCm on ubuntu confirmed.

[NicolasHug]

Thanks for the PR @tvukovic-amd. Before we merge this, can you help me understand why we are removing image.cpp from the sources, and also why the "hipified" source doesn't contain the proper PyInit_image definition?

vision/setup.py

Lines 284 to 285 in 085c7fd

	# we need to exclude this in favor of the hipified source
	sources.remove(image_dir / "image.cpp")

[tvukovic-amd]

• image.cpp is removed from sources only in ROCm case in this PR.
• "hipified" source doesn't contain the proper PyInit_image definition because it is defined in image.cpp, so I moved it to common.cpp in image directory. This is Windows specific definition which wasn't recognized on PR mentioned since it was tested on ROCm on Linux.

[NicolasHug]

@tvukovic-amd can you please merge with main so we can merge this?

[NicolasHug]

Hm, I'm not sure what's going on but it looks like something went wrong with the merge, I see 173 lines added on the diff.

[github-actions]

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py