-
Notifications
You must be signed in to change notification settings - Fork 7k
Support specifying a torch range #8936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8936
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 8 Pending, 1 Unrelated FailureAs of commit 72b8fc4 with merge base d28001e ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @oraluben , is it an option for you to just disable / ignore the pip warning? I sympathize with the release challenges, I wouldn't be able to guarantee that the |
@NicolasHug Thanks for your reply! For us we want to keep pip dependency resolving working (for example,
Ofc it would be best to get this merged in upstream, I think our scenerio would also be a common use case for some other users/companies. Otherwise we might have to maintain a small patch locally... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation: we're using a custom pytorch build and have patch release more recently than upstream. While those updates do not change any abi, we want to allow torchvision/torchaudio (pytorch/audio#3886) to tolerance the changed pytorch version when we update pytorch, otherwise pip will raise a warning.
In this PR, we add two new envionment variable to generate a version range for pytorch.