Provide a save/restore API which does not require every tensor to be … #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1870 |
ailzhang
reviewed
May 29, 2020
| controls whether every host's master (if ``global_master`` is ``False``) | ||
| saves the content, or only the global master (ordinal 0). | ||
| Default: False | ||
| """ |
There was a problem hiding this comment.
Btw maybe we could add a warning here about "sharing storage" is not preserved after save-load.
(it's preserved for CPU/CUDA backend so good to clarify. ;)
There was a problem hiding this comment.
We do have a section in our docs talking about that, but I guess we can add something here (and xm.save()) as well.
…loaded on host memory during the save operation.
dlibenzi
force-pushed
the
lowmem_serialization
branch
from
5bb0b43 to
91af76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…loaded on host memory during the save operation.