Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page object e2e tests #139

Merged
merged 2 commits into from
Oct 31, 2024
Merged

add page object e2e tests #139

merged 2 commits into from
Oct 31, 2024

Conversation

ALegchilov
Copy link
Contributor

@ALegchilov ALegchilov commented Oct 30, 2024

Description

Please describe your changes and any new features you're introducing, or issues you're fixing.

  • Updated the CHANGELOG.md.
  • Updated package version in package.json, package-lock.json.
  • Checked that there aren't other open pull requests for the same issue/update.
  • Checked that your contribution follows the project's contribution guidelines.
  • Added corresponding unit/E2E tests
  • Unit and E2E pass

Related Issues

#138

CHANGELOG.md Outdated
@@ -14,9 +14,12 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how

:microscope: - experimental

## [unreleased]
- :pencil: added page object end-to-end tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it to 2.0.0. it will a part of release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@ALegchilov ALegchilov merged commit ede43cf into v2 Oct 31, 2024
5 checks passed
AlexGalichenko added a commit that referenced this pull request Dec 4, 2024
* reworked page object approach (#134)
* updated dependency to qavajs core (#136)
* removed utils (#137)
* fixed typings
* fixed unit test
* updated workflow to run tests on v2
* add page object e2e tests (#139)
* add memory processor to playwrightLocator parameter type (#140)

---------

Co-authored-by: Alexandr Legchilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants