Dialog rework #148
Dialog rework #148
Conversation
|
|
|
||
| ```gherkin | ||
| Scenario: accept alert | ||
| Given I will wait for dialog |
There was a problem hiding this comment.
To be honest it is not obvious what this step is for, future tesnse confuses a bit.
Lets consider 2 other solutions:
- Rename the step to
Given I set alert listener
or more elegant solution - Using BeforeAll hook check if some of pickles include 'alert' keyword and then set the listener.
There was a problem hiding this comment.
For me listener is more programming specific. I want to use this I will wait for other types of event emitters available in playwright
There was a problem hiding this comment.
Given I expect alert will appear in this scenario
There was a problem hiding this comment.
Expect already has meaning of assertion
There was a problem hiding this comment.
To be honest I don't really like to make use of steps that dos not represent a business logic.
I know, this is not a silver bullet last option is adding a listener using a tag expression.
There was a problem hiding this comment.
I agree, but making it implicit will add more constraints and increase support cost
Description
Please describe your changes and any new features you're introducing, or issues you're fixing.
Related Issues
Please link any related issues or bug reports that this PR will address.