add max players feature & option to hide offline players

[VillainsRule]

closes #344, closes #353
i did something good
this took way too long

[VillainsRule]

bonus commit!!

[VillainsRule]

adding that because I think that modders of qbreader (only me sob) would benefit from having owner information idk remove it if you want

[geoffrey-wu]

You should test your PRs before submitting them—currently, you can't connect to a room because room.players[room.ownerId].username won't work because players are created after the server room calls room.connection, which must necessarily happen after checking if the player is allowed to join. (I'm putting in a fix for this now)

[VillainsRule]

ops i was tired it worked in theory fr

[VillainsRule]

thanks lol <3

[geoffrey-wu]

No problem! For #353 I was thinking a global cap on the number of players in a room (so not room-specific)

[VillainsRule]

oh wait what i didn't get that sob
that sounds like a terrible idea tho some kid would just duplicate tabs and cap it

[geoffrey-wu]

This already seems like an issue with a per-room setting? Also I was thinking like 500 for the global cap which is the upper end of what you have.

[geoffrey-wu]

Thanks for the PR!

[VillainsRule]

for (let i = 0; i < 500; i++) new WebSocket(`wss://qbreader.org/multiplayer/cocaine?roomName=cocaine&userId=cocaine${i}&username=cocaine`);

honestly i'm not sure why you thought this was at all a good idea
you should at least have a disable option and disable this until you've fixed websocket botting

[geoffrey-wu]

Sorry how does your solution fix this problem? Also there's nothing stopping people from making a million rooms, etc.

[VillainsRule]

it doesn't fix the problem, i misinterpreted the issue, i just think the original issue idea is not particularly smart

yeah people can also still make 1 million rooms if they want to, literally add .close(); to the code up there and change the for loop #