Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(tooling): helper script to convert png to ico #548

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Sep 2, 2024

No description provided.

@github-actions github-actions bot added enhancement New feature or request quality Tests, project resiliency, etc. labels Sep 2, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (246d285) to head (3218191).

Files with missing lines Patch % Lines
...is_deployment_toolbelt/shortcuts/icon_converter.py 0.00% 23 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   71.08%   70.55%   -0.53%     
==========================================
  Files          46       47       +1     
  Lines        3095     3118      +23     
  Branches      666      669       +3     
==========================================
  Hits         2200     2200              
- Misses        701      724      +23     
  Partials      194      194              
Flag Coverage Δ
unittests 69.98% <0.00%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...is_deployment_toolbelt/shortcuts/icon_converter.py 0.00% <0.00%> (ø)

@Guts Guts merged commit e845838 into main Sep 3, 2024
25 checks passed
@Guts Guts deleted the feature/add-util-to-convert-png-to-ico branch September 3, 2024 04:21
@Guts Guts added tooling Development tooling and removed enhancement New feature or request quality Tests, project resiliency, etc. labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants