Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a plugin url was like "https://mypluginrepo.example.com/download.php?plugin=MyPlugin", it raises an error as "?" and "=" where encoded
Trace: 404 Client Error: Not Found for url: https://mypluginrepo.example.com/download.php%3Fplugin%3DMyPlugin
The issue is that quote() would encode the entire URL including the protocol and special characters that should remain unencoded (like ://?=). This would break the URL structure.
download_remote_file_to_local
userequests
. Let it handle the encoding part and provide instead the base url and query params.