This repository was archived by the owner on Dec 8, 2024. It is now read-only.
Add ability to create compounds from file-like objects #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a six dependency to make life easier
larsbratholm
approved these changes
Feb 5, 2019
zaspel
pushed a commit
to zaspel/qml
that referenced
this pull request
Jul 29, 2019
* Made Compound able to read file-like objects I added a six dependency to make life easier * Give Compound a name only if there is a filename
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change that allows Compound objects to be created without needing to have a file on disk. It follows a very similar approach to
ase: The function now changes whether user passes a string and, if not, assumes it to be a file object.I also added a dependency to six for making Python 2 compatibility easier, and a unit test to cover this new functionality.