Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

Directory structure #71

Merged
merged 4 commits into from
Aug 15, 2018
Merged

Directory structure #71

merged 4 commits into from
Aug 15, 2018

Conversation

andersx
Copy link
Member

@andersx andersx commented Aug 4, 2018

  • Reverts to the old directory structure.
  • Puts FCHL code in it's own module/directory, similarly to the ARAD and Aglaia modules.
  • Changes ModuleNotFoundError to ImportError in aglaia.py (ModuleNotFoundError only exists in Python 3.6 or newer). We can revert this after Python2 is no longer supported, as it is a more correct error.
  • Fixes erroneous authors in some file headers.
  • Cleans up setup.py: Remove defunct compile info for FCHL, and reinstates the use of mkldiscover.

larsbratholm
larsbratholm previously approved these changes Aug 4, 2018
Copy link
Collaborator

@larsbratholm larsbratholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Member

@charnley charnley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@andersx andersx merged commit 888fb89 into qmlcode:develop Aug 15, 2018
zaspel pushed a commit to zaspel/qml that referenced this pull request Jul 29, 2019
* Reverts to old directory structure
* Fix authors in several __init__ files that are updated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants