Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to check OPENAI_KEY when using non OpenAI models #855

Closed
nakamichiworks opened this issue Apr 10, 2024 · 1 comment · Fixed by #858
Closed

No need to check OPENAI_KEY when using non OpenAI models #855

nakamichiworks opened this issue Apr 10, 2024 · 1 comment · Fixed by #858

Comments

@nakamichiworks
Copy link

PR Agent silently fails when I use the non OpenAI models such as Bedrock in Github Actions if I do not set OPENAI_KEY.

This failure is caused by unnecessarily checking existence of OPENAI_KEY in the following code, which seems to be removed safely.

https://github.com/Codium-ai/pr-agent/blob/f0c5aec0e431461d751d802b6a7132f32c940c38/pr_agent/servers/github_action_runner.py#L50
@mrT23
Copy link
Collaborator

mrT23 commented Apr 11, 2024

you are welcome to open to open a PR to address this

pkvach added a commit to pkvach/pr-agent that referenced this issue Apr 12, 2024
@pkvach
Handle OPENAI_KEY not set error in github_action_runner.py
4c83bf6 
Fixes qodo-ai#855
@pkvach pkvach mentioned this issue Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle OPENAI_KEY not set error in github_action_runner.py pkvach/pr-agent
2 participants
@nakamichiworks @mrT23