Enhancement request for JSON IO-related APIs #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
Cool, much appreciated, sorry that it took so long to merge! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends save/load APIs.
The first commit adds
io-accepting variants for the save/load functions (e.g.,save(Stream(format"vegalite", io), spec))The second commit adds
indentkeyword argument so thatsavefunctions can pretty-print JSON.The third commit lets
show(IOContext(stdout, :compact=>false), "text/plain", spec)use the pretty-printed JSON andvl"..."macro to produce evaluatable Julia code. This is useful, e.g., for generating executable Julia code fromDataVoyageroutput.