Add xy test #213
Merged
Add xy test #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleby
approved these changes
Nov 14, 2019
braised-babbage
force-pushed
the
feature/add-xy-test
branch
from
00a6edf to
381e960
Compare
|
@kilimanjaro why is it succeeding? |
notmgsk
reviewed
Nov 14, 2019
tests/gate-tests.lisp
Outdated
| (flet ((eval-prog (quil-string) | ||
| (let ((qvm (make-qvm 2))) | ||
| (load-program qvm (with-output-to-quil | ||
| quil-string)) |
Are the tests pulling master? I forget how we set that up. |
|
@notmgsk https://gitlab.com/rigetti/forest/qvm/-/jobs/350247291 this job uses cl-quil/quilc 1.12.0 and it worked. we pull |
Puzzling |
added 2 commits
November 18, 2019 14:51
braised-babbage
force-pushed
the
feature/add-xy-test
branch
from
381e960 to
23ab407
Compare
|
@kilimanjaro did we figure out why it was succeeding before? |
Not I |
stylewarning
approved these changes
Nov 19, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a sanity check.