Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement promote_to_multi when converting WKB to sfc #2369

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+303 −32
Open

Implement promote_to_multi when converting WKB to sfc #2369

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3c0b00b
collect unique sf types using a bitmask
paleolimbot Mar 30, 2024
d994803
structure of promotion code
paleolimbot Mar 30, 2024
50d3fd6
maybe with promote
paleolimbot Mar 31, 2024
1fd150d
plumb option
paleolimbot Mar 31, 2024
34f2827
plumb into R
paleolimbot Mar 31, 2024
a8c4091
maybe fix
paleolimbot Mar 31, 2024
4331240
maybe revert wkb to existing usage
paleolimbot Mar 31, 2024
5515f3c
whoops
paleolimbot Mar 31, 2024
bcb241d
add tests
paleolimbot Mar 31, 2024
600564b
maybe fix check
paleolimbot Mar 31, 2024
39cb85c
whoops
paleolimbot Mar 31, 2024
99ca072
add doc
paleolimbot Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
maybe fix check
@paleolimbot
paleolimbot committed Mar 31, 2024
commit 600564bb58e5813149ebfd3bad647a93d58ea5d0
10 changes: 4 additions & 6 deletions tests/testthat/test-wkb.R
View file
Original file line number Diff line number Diff line change
@@ -97,10 +97,9 @@ test_that("st_as_sfc() for WKB can promote_to_multi for multilinestring + linest

# st_as_sfc() assigns different attribute order than st_cast, but we ony care
# about whether the geometries are correct
expect_equal(
expect_equivalent(
st_as_sfc(wkb_mixed, promote_to_multi = TRUE),
st_cast(sfc_mixed, "MULTILINESTRING"),
ignore_attr = TRUE
st_cast(sfc_mixed, "MULTILINESTRING")
)
})

@@ -120,9 +119,8 @@ test_that("st_as_sfc() for WKB can promote_to_multi for multipolygon + polygon",

# st_as_sfc() assigns different attribute order than st_cast, but we ony care
# about whether the geometries are correct
expect_equal(
expect_equivalent(
st_as_sfc(wkb_mixed, promote_to_multi = TRUE),
st_cast(sfc_mixed, "MULTILINESTRING"),
ignore_attr = TRUE
st_cast(sfc_mixed, "MULTILINESTRING")
)
})