Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When asserting queries performed, insert placeholder query for release save-point #1168

Merged
merged 5 commits into from
May 9, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented May 9, 2024

SQL Server does not support releasing save-points. They are automatically released when transitions are committed/rolled-back.

When the number of queries performed is asserted in tests, it is assumed that release save-point is supported. To work around this a dummy placeholder query is inserted if a transaction is saved at the start of the queries.

@aidanharan aidanharan changed the title Perform noop query when releasing savepoint Perform no-op query when releasing savepoint May 9, 2024
@aidanharan aidanharan changed the title Perform no-op query when releasing savepoint When asserting queries performed, insert placeholder query for release save-point May 9, 2024
@aidanharan aidanharan marked this pull request as ready for review May 9, 2024 19:56
@aidanharan aidanharan merged commit 95b0c8e into main May 9, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the release-save-point-testing branch May 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant