Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate missed lease_connection calls #1187

Merged
merged 4 commits into from
May 23, 2024

Conversation

aidanharan
Copy link
Contributor

Fix ActiveRecord::ConnectionHandlingTest#test_0010_common APIs don't permanently hold a connection when permanent checkout is deprecated or disallowed.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9172172552/job/25218095721

5) Failure:
ActiveRecord::ConnectionHandlingTest#test_0010_common APIs don't permanently hold a connection when permanent checkout is deprecated or disallowed [/usr/local/bundle/bundler/gems/rails-cb977226eae5/activerecord/test/cases/connection_handling_test.rb:177]:

@aidanharan aidanharan marked this pull request as ready for review May 23, 2024 18:34
@aidanharan aidanharan merged commit 634bc2a into main May 23, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the eliminate-missed-connection-leases branch May 23, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant