Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor of Support insert_all and upsert_all using MERGE #1314

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Small refactor of Support insert_all and upsert_all using MERGE #1314

merged 2 commits into from
Mar 20, 2025

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Mar 20, 2025 •
edited
Loading

Small refactor to reduce the size of the build_insert_sql(insert) method.

@aidanharan aidanharan requested a review from andyundso March 20, 2025 10:12
@aidanharan aidanharan marked this pull request as ready for review March 20, 2025 10:12
@aidanharan
Copy link
Contributor Author

@andyundso #1312 looks good! Just made small in this PR if you want to merge it into your branch.

andyundso
andyundso approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@andyundso andyundso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better to read!

@aidanharan aidanharan merged commit db8199a into support-insert-and-upsert-main Mar 20, 2025
2 checks passed
@aidanharan aidanharan deleted the ah-support-insert-and-upsert-main branch March 20, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyundso andyundso andyundso approved these changes

Assignees
No one assigned
Labels
rails-8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidanharan @andyundso