Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6: Fixed migration test #761

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Apr 8, 2020

Fixes the failing test FullyQualifiedIdentifierTestSQLServer::remote server#test_0005_should use fully qualified table name in insert statement.

Before
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/672479581

6728 runs, 18679 assertions, 53 failures, 14 errors, 25 skips

After
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/672538462

6728 runs, 18688 assertions, 52 failures, 13 errors, 25 skips

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@aidanharan aidanharan marked this pull request as ready for review April 8, 2020 14:59
@aidanharan aidanharan changed the title Fixed migration test Rails 6: Fixed migration test Apr 8, 2020
@wpolicarpo wpolicarpo merged commit f89a893 into rails-sqlserver:6-0-dev Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants