Rails 6: Clean coerced tests #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rced fixed in rails/50684d15c6546d3050d93896612edd9c5a0fca62
updated in rails/de2f1e073b37f98a99334a909b8bc29f36ad506b
test "column names are quoted when using #from clause and model has ignored columns" fixed in rails/d53b259a29e77a60a02e9c219661e19ef62ef9aa
tests been fiexd in active recorde
|
Looks good. Could you squash your commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run the tests suite without the
coerced tests.rbfile and found old coerced tests that been fix in active record.I removed old tests and tried to update tests to match the original tests.
I added comments to tests.