Cookies are signed and encrypte. #105
Conversation
Encrypts session cookie.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
KartikKumarSahoo
changed the title
| @@ -65,7 +65,7 @@ class ActiveRecordStore < ActionDispatch::Session::AbstractStore | |||
| end | |||
|
|
|||
| private | |||
| def get_session(request, sid) | |||
| def get_session(request, sid) # NOTE: Doesn't get invoked. | |||
There was a problem hiding this comment.
Why this comment? I think it is called in versions of Rails before to 5.0
|
|
||
| def write_session(request, sid, session_data, options) | ||
| logger.silence_logger do | ||
| sid ||= get_cookie(request) |
There was a problem hiding this comment.
Why do we need to read the sid from the cookie? Is not it already passed to write_session?
|
I'm going to close this PR as it become stale. Going to use implementation in #140 instead. Thank you for your patch. |
Encrypts session cookie.