Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert_dom strict parameter #122

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jyeharry
Copy link

@jyeharry jyeharry commented Mar 10, 2025

  • Add macos to supported platforms in Gemfile.lock
  • Add failing test for assert_dom collapsing whitespace
  • Add strict parameter to assert_dom

Fixes #121

Adds a :strict key to the equality test hash for assert_dom, so that we can specify whether or not to ignore excess whitespace just as the browser does.

I prefer the solution in #123. This was created since the issue I created specifically mentioned creating a :strict parameter.

@flavorjones
Copy link
Member

flavorjones commented Mar 10, 2025

OK, main is green, so please rebase when you have a chance.

@jyeharry jyeharry force-pushed the feature/assert_dom-ignore-whitespace branch from 6c7c2d7 to 6563fa4 Compare March 15, 2025 02:48
@jyeharry
Copy link
Author

@flavorjones Rebased and tests and ci is passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

assert_dom should ignore whitespace just like assert_dom_equal
2 participants