Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Redo simplify multi agent config dict: Reverted b/c seemed to break test_typing (non RLlib test). #17046

Merged
merged 30 commits into from
Jul 15, 2021
Merged

[RLlib] Redo simplify multi agent config dict: Reverted b/c seemed to break test_typing (non RLlib test). #17046

merged 30 commits into from
Jul 15, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jul 13, 2021 •
edited
Loading

Redo simplify multi agent config dict (#16565): Reverted b/c broke test_typing.

Also reinstates pettingzoo test case.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

sven1977 added 24 commits June 19, 2021 16:53
@sven1977
fix
a5d3aa5
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
7194ea4 
…iagent_config_simplification
@sven1977
fix
0526388
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
c9a396a 
…iagent_config_simplification
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
0f95e49 
…iagent_config_simplification

# Conflicts:
#	rllib/evaluation/rollout_worker.py
#	rllib/examples/multi_agent_independent_learning.py
#	rllib/examples/multi_agent_parameter_sharing.py
#	rllib/examples/pettingzoo_env.py
#	rllib/tests/test_pettingzoo_env.py
@sven1977
fix and lint
acc0767
@sven1977
merge
0531fe2
@sven1977
fix
2574484
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
819c42b 
…iagent_config_simplification
@sven1977
fix
9605b5a
@sven1977
fix.
0d09f17
@sven1977
fix.
2cd16f5
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
2724ea3 
…iagent_config_simplification
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
2b97b4f 
…iagent_config_simplification

# Conflicts:
#	rllib/examples/multi_agent_custom_policy.py
@sven1977
wip.
e3d4bdd
@sven1977
wip.
c3fd510
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
5d2e43d 
…iagent_config_simplification
@sven1977
wip.
7bdf738
@sven1977
wip.
66798b9
@sven1977
wip.
c1e5699
@sven1977
LINT.
0d899a3
@sven1977
fix.
8c03aa7
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into mult…
77da113 
…iagent_config_simplification
@sven1977
Merge branch 'multiagent_config_simplification' into redo_simplify_mu…
7b022e6 
…lti_agent_config_dict
@sven1977 sven1977 requested a review from michaelzhiluo July 13, 2021 21:00
@sven1977 sven1977 merged commit 649580d into ray-project:master Jul 15, 2021
@richardliaw richardliaw mentioned this pull request Jul 27, 2021
Closed
@mgerstgrasser mgerstgrasser mentioned this pull request Dec 28, 2021
Closed
2 tasks
@sven1977 sven1977 deleted the redo_simplify_multi_agent_config_dict branch August 12, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelzhiluo michaelzhiluo michaelzhiluo approved these changes

Assignees

@michaelzhiluo michaelzhiluo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @michaelzhiluo