[build] Incorrect CMake config causes example to fail to compile #606
Comments
|
Could you submit a PR? |
|
Come to think of it, that is not neccessary the right solution. Why not just reference the header from souce folder? The problem may come when user uses standalone CMake but specify custom build output folder. |
Ye, that the |
raysan5
changed the title
a3f
added a commit
to a3f/raylib
that referenced
this issue
Jul 29, 2018
Remove that link_libraries_to_executable() hack and defines a proper raylib target that can be used with target_link_libraries. The same target is also available for external (user) code by using find_package(raylib). This results in: - Remove hardcoded build directories from examples and games CMakeLists.txt - Allow rlgl_standalone and other special examples to be built easily - Allow CMake projects to find_package(raylib instead of fiddling with pkg-config - Makes code a little more maintainable - Fixes raysan5#471, raysan5#606. - Makes code less confusing by removing the double use of PLATFORM (raysan5#584). Note that this is still not _The Right Way_(TM), because normally raylib-config.cmake (or its includes) would be automatically generated. I didn't manage to get that to work though, so I went the easier route of just wrapping pkg_check_modules for consumption by find_package.
|
I will merge #608 soon that should fix this problem by removing the hardcoded paths. Please test and report if it fixes your issue |
a3f
added a commit
to a3f/raylib
that referenced
this issue
Jul 29, 2018
Remove that link_libraries_to_executable() hack and defines a proper raylib target that can be used with target_link_libraries. The same target is also available for external (user) code by using find_package(raylib). This results in: - Remove hardcoded build directories from examples and games CMakeLists.txt - Allow rlgl_standalone and other special examples to be built easily - Allow CMake projects to find_package(raylib instead of fiddling with pkg-config - Makes code a little more maintainable - Fixes raysan5#471, raysan5#606. - Makes code less confusing by removing the double use of PLATFORM (raysan5#584). Note that this is still not _The Right Way_(TM), because normally raylib-config.cmake (or its includes) would be automatically generated. I didn't manage to get that to work though, so I went the easier route of just wrapping pkg_check_modules for consumption by find_package.
a3f
added a commit
to a3f/raylib
that referenced
this issue
Jul 29, 2018
Remove that link_libraries_to_executable() hack and defines a proper raylib target that can be used with target_link_libraries. The same target is also available for external (user) code by using find_package(raylib). This results in: - Remove hardcoded build directories from examples and games CMakeLists.txt - Allow rlgl_standalone and other special examples to be built easily - Allow CMake projects to find_package(raylib instead of fiddling with pkg-config - Makes code a little more maintainable - Fixes raysan5#471, raysan5#606. - Makes code less confusing by removing the double use of PLATFORM (raysan5#584). Note that this is still not _The Right Way_(TM), because normally raylib-config.cmake (or its includes) would be automatically generated. I didn't manage to get that to work though, so I went the easier route of just wrapping pkg_check_modules for consumption by find_package.
a3f
added a commit
to a3f/raylib
that referenced
this issue
Jul 29, 2018
Remove that link_libraries_to_executable() hack and defines a proper raylib target that can be used with target_link_libraries. The same target is also available for external (user) code by using find_package(raylib). This results in: - Remove hardcoded build directories from examples and games CMakeLists.txt - Allow rlgl_standalone and other special examples to be built easily - Allow CMake projects to find_package(raylib instead of fiddling with pkg-config - Makes code a little more maintainable - Fixes raysan5#471, raysan5#606. - Makes code less confusing by removing the double use of PLATFORM (raysan5#584). Note that this is still not _The Right Way_(TM), because normally raylib-config.cmake (or its includes) would be automatically generated. I didn't manage to get that to work though, so I went the easier route of just wrapping pkg_check_modules for consumption by find_package.
|
Hey there, it appears to have solved the issue after I pulled the newest commit |
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested with MSVC 2017 internal CMake support, all examples would fail to compile due to them being unable to locate raylib.h. This one additional line will fix the problem:
include_directories("../release/include")when added to examples/CMakeLists.txt
The text was updated successfully, but these errors were encountered: