Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Create function to retrieve frame busy time (non-sleeping time) #3781

Closed
wants to merge 2 commits into from
Closed

Conversation

bmbkr
Copy link
Contributor

@bmbkr bmbkr commented Feb 4, 2024

No description provided.

@bmbkr
Copy link
Contributor Author

bmbkr commented Feb 4, 2024

I still need to update documentation throughout the repo to include this new function.

That being said, I'm eagerly awaiting your thoughts on this new functionality @raysan5

@raysan5
Copy link
Owner

raysan5 commented Feb 4, 2024

@bmbkr I prefer to avoid exposing this internal state, most users probably do not need it and advance users can implement it for their needs or just enable SUPPORT_CUSTOM_FRAME_CONTROL on config.h to have full control over the frame.

Exposing this state would imply exposing other internal states that I think most users do not need at the moment.

@raysan5 raysan5 closed this Feb 4, 2024
@bmbkr
Copy link
Contributor Author

bmbkr commented Feb 4, 2024

@raysan5 Understood. Perhaps this can be exposed at some point in the future as part of a metrics interface, simply as a ratio of busy to sleep time. Would be particularly useful for performance measurement, although as you said you can just recompile with custom frame control.

@raysan5
Copy link
Owner

raysan5 commented Feb 4, 2024

@bmbkr there was a new feature in that line in the past (#1295) but it required to many changes and coupling and it was discarded...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants