Allow use of main instead of android_main #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by raysan5#504. Instead of requiring the user to do PLATFORM_ANDROID #ifdefery, have the android_main entry point exported by raylib and call the user-defined main. This way many games could (in theory) run unmodified on Android and elsewhere. This is untested!
a3f
commented
Mar 16, 2018
| /* TODO should we maybe report != 0 return codes somewhere? */ | ||
| (void)main(1, (char*[]){ arg0, NULL }); | ||
| } | ||
| /* TODO add this to header, if apps really need it) */ |
There was a problem hiding this comment.
Actually, user doesn't need it, android app lifecycle is managed internally by raylib.
There was a problem hiding this comment.
android_native_app_glue.h has more info about that structure.
|
Just waiting to get some time to test this change properly when merging... I'm closing academic term this week and I'm a bit busy for long implementation/testing sessions... |
|
Merged. Need to test it properly. |
|
Amazing! It works like a charm! :D |
a3f
added a commit
to a3f/raylib
that referenced
this pull request
Jul 29, 2018
With the recent CMake cleanup, getting raylib's dependencies for use when building rlgl_standalone is quite straight forward, so lets enable it again. Fixes raysan5#508, just properly this time. :)
a3f
added a commit
to a3f/raylib
that referenced
this pull request
Jul 29, 2018
With the recent CMake cleanup, getting raylib's dependencies for use when building rlgl_standalone is quite straight forward, so lets enable it again. Fixes raysan5#508, just properly this time. :)
a3f
added a commit
to a3f/raylib
that referenced
this pull request
Jul 29, 2018
With the recent CMake cleanup, getting raylib's dependencies for use when building rlgl_standalone is quite straight forward, so lets enable it again. Fixes raysan5#508, just properly this time. :)
a3f
added a commit
to a3f/raylib
that referenced
this pull request
Jul 29, 2018
With the recent CMake cleanup, getting raylib's dependencies for use when building rlgl_standalone is quite straight forward, so lets enable it again. Fixes raysan5#508, just properly this time. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #504.
Instead of requiring the user to do
PLATFORM_ANDROID#ifdefery,have the
android_mainentry point exported by raylib and callthe user-defined
main. This way many games could (in theory)run unmodified on Android.
This is untested!