-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn watch doesn't get changes from all files on Linux and Windows #989
Labels
Comments
I've done a bit more of research and this looks like a platform limitation. |
molant
added a commit
to molant/cli
that referenced
this issue
Feb 19, 2020
Use `chokidar` to track file system changes as soon it will throw an error if the platform does not support `{ recursive: true }`. Fix also an error where the built file was not being deleted when the source was removed. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix react-native-community#989 Ref: nodejs/node#29947
molant
added a commit
to molant/cli
that referenced
this issue
Feb 19, 2020
Use `chokidar` to track file system changes as soon it will throw an error if the platform does not support `{ recursive: true }`. Fix also an error where the built file was not being deleted when the source was removed. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix react-native-community#989 Ref: nodejs/node#29947
thymikee
pushed a commit
that referenced
this issue
Feb 20, 2020
Use `chokidar` to track file system changes as soon it will throw an error if the platform does not support `{ recursive: true }`. Fix also an error where the built file was not being deleted when the source was removed. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #989 Ref: nodejs/node#29947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Linux:
Windows:
Description
Trying to work on the CLI project. Running
yarn watch
doesn't detect changes in all files.The ones under
packages/cli/src
are detected, but if I change something in a file nested more deeply it doesn't work (e.g.:packages/cli/src/commands/doctor/info.ts
).Reproducible Demo
I've attached a gif of the issue. It's a bit blurry but hopefully you can see what's going on:
packages/cli/src/bin.ts
gets detectedpackages/cli/commands/doctor/info.ts
goes unnoticedThis happens in Linux and Windows just after cloning and doing
yarn
with node 12 and 13. It looks like the code to watch should work (recursive: true
). Don't know if it is a node limitation in these platforms (ie.: limit on ionodes on Linux) or if it happens on macOS as well.Happy to work on this although I might have to pull an extra package to make it work cross platform.
The text was updated successfully, but these errors were encountered: