Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php73][Php80] Handle empty long array syntax default value on SensitiveConstantNameRector+AddParamBasedOnParentClassMethodRector #4837

Merged
merged 6 commits into from
Aug 23, 2023
Merged

[Php73][Php80] Handle empty long array syntax default value on SensitiveConstantNameRector+AddParamBasedOnParentClassMethodRector #4837

merged 6 commits into from
Aug 23, 2023

Conversation

samsonasik
Copy link
Member

When SensitiveConstantNameRector and AddParamBasedOnParentClassMethodRector combined. Empty long array array() become \ARRAY, see

-    public function run()
+    public function run($default = \ARRAY())

which should be array() lower case without \ prefix.

This PR try to fix it /cc @klimslim

@samsonasik
[Php73][Php80] Handle empty long array syntax default value on Sensit…
073e848 
…iveConstantNameRector+AddParamBasedOnParentClassMethodRector
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @klimslim

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 15ddec3 into main Aug 23, 2023
@samsonasik samsonasik deleted the empty-long branch August 23, 2023 13:21
This was referenced Aug 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik