Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Validate paths in RectorConfig->paths() #5065

Merged
merged 6 commits into from
Sep 24, 2023
Merged

DX: Validate paths in RectorConfig->paths() #5065

merged 6 commits into from
Sep 24, 2023
+44 −0

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 22, 2023 •
edited
Loading

before this PR, rector would not report anything when some paths are configured wrong, e.g. with

    $rectorConfig->paths([
        __DIR__ . '/src/', // correct path
        __DIR__ ."lib/", // note missing "/" before "lib"
    ]);

in 0.18.3 rector would just start scanning and ignore some of the paths (scanning not all files) without further notice

@staabm staabm changed the title Validate paths in RectorConfig->paths() DX: Validate paths in RectorConfig->paths() Sep 22, 2023
@staabm staabm marked this pull request as ready for review September 22, 2023 11:46
@staabm
Copy link
Contributor Author

staabm commented Sep 22, 2023

rebased

@staabm
Copy link
Contributor Author

staabm commented Sep 24, 2023

ping @samsonasik

samsonasik
samsonasik approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @staabm

@samsonasik samsonasik merged commit 0d9b38d into rectorphp:main Sep 24, 2023
@staabm staabm deleted the paths-exist branch September 24, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik

@TomasVotruba TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@staabm @samsonasik