Add simple release process and info for custom helm repo. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jdubrick
reviewed
Nov 13, 2024
Thanks for the input :) I've addressed all comments as part of 200d198 |
Jdubrick
reviewed
Nov 14, 2024
maysunfaisal
approved these changes
Nov 14, 2024
|
@maysunfaisal @Jdubrick I'll need a re-approval / review after one small change I've added. Thanks! |
Jdubrick
approved these changes
Nov 14, 2024
maysunfaisal
approved these changes
Nov 14, 2024
johnmcollier
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Chart.yamlwascharts/ai-software-templates/chatbot/0.1.0and the new one is `charts/ai-software-templates/chatbot/.chart-releaser.yamlis replaced with therelease.yaml. So everytime we cut a new release, e.gv0.1.0the helm packages are pinned.ai-lab-helm-chartsrepository, adds instructions on how someone can create a custom repository for their fork.Which issue(s) this PR fixes:
https://issues.redhat.com/browse/DEVAI-210
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
How to test changes / Special notes to the reviewer:
I have tested the release.yaml here: https://github.com/thepetk/ai-lab-helm-charts/releases/tag/v0.1.0
FYI in case someone wants to import the updated helm repository in their cluster feel free to use my github pages here: https://thepetk.github.io/ai-lab-helm-charts/ as helm repo.