Skip to content

remove redundant odf console enablement #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlbewley
Copy link
Contributor

Fixes #354

Removes Job that enabled ODF console by patching consoles.operator.openshift.io/cluster.

ODF console plugin is automatically enabled as of 4.12 or earlier

ODF console plugin is automatically enabled as of 4.12 or earlier
@strangiato
Copy link
Contributor

@dlbewley are you sure that it is automatically enabled when not using the GUI?

In the doc you linked to in the issue it includes:

In case, this option was unchecked during OpenShift Data Foundation Operator installation

The "unchecked" to me implies that they are only talking about the GUI based install.

@dlbewley
Copy link
Contributor Author

The doc I linked to was ODF 4.12 which is the first version to include this language.

"The Data Foundation console plugin is enabled by default."

I know that using the existing Kustomization leads my ArgoCD to fail to synchronize the ConsolePlugin resource.

I may rebuild my cluster very soon, but I'll seek independent confirmation in the meantime.

@dlbewley
Copy link
Contributor Author

A colleague confirmed Storage -> Data Foundation console plugin automatically enabled when installing 4.18 today.

I'm sure how to prove it in the operator code, but I believe this is the case since 4.12.

@strangiato
Copy link
Contributor

When you install it via the UI the option to enable the console plugin is enabled by default which I think is what they are talking about:

Screenshot 2025-03-13 at 2 55 37 PM

I did a quick install of ODF from the gitops assets on a cluster to test with the console plugin pieces disabled and the console plugin is not enabled by default:

Screenshot 2025-03-13 at 2 59 35 PM Screenshot 2025-03-13 at 2 59 53 PM

@dlbewley
Copy link
Contributor Author

OH so the console Operator Hub install process has some secret sauce it performs beyond simply installing the operatorgroup and subscription. I didn't even know that was a thing. Not sure I care for that. I'll close the PR after I get a chance to redeploy and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODF console enablement is no longer needed
2 participants