Skip to content

Fix semantic versioning control with standard from https://semver.org #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

thekoma
Copy link
Contributor

@thekoma thekoma commented Jan 11, 2021

Fixing the semantic versioning as it won't work from version v0.0.10 because egrep doesn't use the perl regex correctly.
As I was already looking at the code I've found that semver.org has a really good regex already bilt.

Also I've moved the >> to |tee -a to simplify debugging.

Copy link
Collaborator

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit c3ee999 into redhat-cop:master Jan 12, 2021
sabre1041 pushed a commit to sabre1041/group-sync-operator that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants