Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#38 #39

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Fix#38 #39

merged 2 commits into from
Jul 28, 2022

Conversation

raffaelespazzoli
Copy link
Collaborator

Fixes #30
Fixes #38

@raffaelespazzoli
fix redhat-cop#30
aa1856a 
Signed-off-by: raffaelespazzoli <[email protected]>
@raffaelespazzoli
fix redhat-cop#38
8a0a3b4 
Signed-off-by: raffaelespazzoli <[email protected]>
sabre1041
sabre1041 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit 64c916b into redhat-cop:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabre1041 sabre1041 sabre1041 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot impersonate serviceaccount adjust patch to use name instead of labelselector
2 participants
@raffaelespazzoli @sabre1041