Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odo integration tests should use staging devfile registry (registry.stage.devfile.io) #4639

Closed
johnmcollier opened this issue Apr 19, 2021 · 3 comments · Fixed by #4752 or #4775
Closed
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@johnmcollier
Copy link
Member

johnmcollier commented Apr 19, 2021

With #4525 now merged, Odo now supports the new community devfile registry at https://registry.devfile.io, and uses it by default.

While most Odo integration tests don't directly use the registry for testing, there are a few other integration tests that do:

  • odo catalog tests
  • odo create --registry tests
  • odo registry tests

A few of us on devfile services were chatting and think that for the integration tests in Odo that do use the registry, it might be a good idea to use the staging devfile registry (https://registry.stage.devfile.io) instead of production for a couple reasons:

  • It'll reduce unnecessary load on the production registry, especially when there's multiple test runs running concurrently
  • The staging and production registries are largely identical, the only difference is when they are updated
    • Staging is updated with each commit to master in devfile/registry, production is updated manually each Wednesday
  • Telemetry will eventually be enabled on the production devfile registry and we do not want the integration tests polluting the data we get back from the telemetry.

Let me know if this sounds like a reasonable thing to do, or if there's any concerns about this approach.

@johnmcollier
Copy link
Member Author

I just want to clarify too, this is not something that necessarily needs to be done urgently or soon - we're still a ways away from implementing telemetry on the devfile registry, and the extra load that the tests are creating on the registry is useful for us as we monitor load in this transition period.

But it is something that will need to be done once we implement telemetry

@kadel kadel added priority/Medium Nice to have issue. Getting it done before priority changes would be great. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Apr 28, 2021
@josephca
Copy link
Contributor

josephca commented May 26, 2021

Currently, the following tests are using the staging registry - #4679

  • odo catalog test
  • odo registry tests

Thus, odo create --registry tests is remained to use the staging registry for the test.
(Update: PR #4752 is opened )

@valaparthvi
Copy link
Contributor

This issue is still in progress w.r.t. PR #4775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants