Switch to use parser library

[yangcao77]

What type of PR is this?

/area devfile
/kind code-refactoring

What does does this PR do / why we need it:
This PR removes the parser pkg from odo repo, and use parser from devfile/library instead
This PR also integrate odo with the devfile go structs defined in devfile/api

Which issue(s) this PR fixes:

Fixes #4117

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:
run integration tests and unit tests to make sure no regression has been introduced

[yangcao77]

This PR is currently blocked by: devfile/api#203
the yaml tags need to be added in structs for devfile writer to work

[kadel]

@yangcao77 It looks like there is something broken in headlight the paths (/ vs \)
Windows unit tests are failing on

--- FAIL: TestCopyDirWithFS (0.00s)
    --- FAIL: TestCopyDirWithFS/case_1:_folder_with_a_nested_file_and_folder (0.00s)
        util_test.go:2286: MoveDir() error = chmod C:\Users\travis\AppData\Local\Temp\destination/blah.js: file does not exist, wantErr false
        util_test.go:2340: some folder were not created
        util_test.go:2344: some files were not created
--- FAIL: TestGitSubDir (0.00s)
    --- FAIL: TestGitSubDir/case_1:_normal_sub_dir_exist (0.00s)
        util_test.go:2570: GitSubDir() error = chmod C:\Users\travis\AppData\Local\Temp\destination\java/main.java: file does not exist, wantErr false
        util_test.go:2611: all files were not copied

Notice the forward flash instead of back slash in the path.

[yangcao77]

@kadel that is wired.. I did not modify those two functions / files. I will rebase with the latest master to see.

[codecov]

Codecov Report

Merging #4188 (dbc7921) into master (0dea26a) will decrease coverage by 0.87%.
The diff coverage is 21.77%.

@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
- Coverage   42.56%   41.69%   -0.88%     
==========================================
  Files         156      140      -16     
  Lines       13266    12783     -483     
==========================================
- Hits         5647     5330     -317     
+ Misses       7017     6887     -130     
+ Partials      602      566      -36     

Impacted Files	Coverage Δ
pkg/component/component.go	22.44% <ø> (ø)
pkg/component/component_full_description.go	0.00% <0.00%> (ø)
pkg/component/devfile_repr.go	0.00% <ø> (ø)
pkg/config/env_var.go	47.82% <0.00%> (ø)
pkg/devfile/adapters/common/command_simple.go	81.39% <ø> (ø)
pkg/devfile/adapters/common/command_supervisor.go	0.00% <ø> (ø)
pkg/devfile/adapters/common/generic.go	16.25% <0.00%> (ø)
pkg/devfile/adapters/docker/component/adapter.go	56.98% <0.00%> (ø)
pkg/devfile/adapters/docker/utils/utils.go	85.13% <ø> (ø)
pkg/devfile/adapters/helper.go	8.00% <ø> (ø)
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8304e...ac74a29. Read the comment docs.

[kadel]

This PR is currently blocked by: devfile/api#203
the yaml tags need to be added in structs for devfile writer to work

@yangcao77 I see the tests are passing. Is this PR still blocked on devfile/api#203?

[yangcao77]

@kadel It's unblocked now. people can start reviewing the PR.

[kadel]

/retest

[kadel]

Good job @yangcao77
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mik-dass]

CI is green
/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[yangcao77]

@mik-dass Can you help add back the lgtm label? the label was removed as I did a rebase

[mik-dass]

@mik-dass Can you help add back the lgtm label? the label was removed as I did a rebase

Sure.
/lgtm