Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extended search commands #151

Merged
merged 30 commits into from
Jul 5, 2023
Merged

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Jun 18, 2023

This PR adding support for the commands:
FT.SPELLCHECK
FT.PROFILE
FT.SUGADD
FT.SUGDEL
FT.SUGGET
FT.SUGLEN

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Patch coverage: 98.90% and project coverage change: +0.22 🎉

Comparison is base (16f7291) 93.59% compared to head (dd50d99) 93.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   93.59%   93.82%   +0.22%     
==========================================
  Files          81       82       +1     
  Lines        4869     5082     +213     
  Branches      460      476      +16     
==========================================
+ Hits         4557     4768     +211     
  Misses        185      185              
- Partials      127      129       +2     
Impacted Files Coverage Δ
src/NRedisStack/Search/SearchCommandBuilder.cs 91.41% <95.74%> (+1.58%) ⬆️
src/NRedisStack/Search/Query.cs 98.15% <96.55%> (ø)
src/NRedisStack/Pipeline.cs 100.00% <100.00%> (ø)
src/NRedisStack/ResponseParser.cs 96.17% <100.00%> (+0.64%) ⬆️
src/NRedisStack/Search/FTSpellCheckParams.cs 100.00% <100.00%> (ø)
src/NRedisStack/Search/SearchCommands.cs 100.00% <100.00%> (ø)
src/NRedisStack/Search/SearchCommandsAsync.cs 96.03% <100.00%> (+1.13%) ⬆️
src/NRedisStack/Transactions.cs 88.23% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested review from sazzad16, a team and chayim June 19, 2023 11:56
@shacharPash shacharPash changed the title Support FT.SPELLCHECK Command Support Search Command Jun 19, 2023
@chayim chayim changed the title Support Search Command Add support for extended search commands Jul 2, 2023
@chayim chayim added the breakingchange API or breaking change label Jul 5, 2023
@shacharPash shacharPash merged commit 9a2cd5d into master Jul 5, 2023
@shacharPash shacharPash deleted the ftSearchCommands branch July 5, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants