Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GRAPH.DELETE returning boolean #152

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Support GRAPH.DELETE returning boolean #152

merged 2 commits into from
Jun 27, 2023

Conversation

shacharPash
Copy link
Contributor

No description provided.

@shacharPash shacharPash added bug Something isn't working breakingchange API or breaking change labels Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.20 ⚠️

Comparison is base (5f4e766) 93.67% compared to head (27e5a36) 93.48%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   93.67%   93.48%   -0.20%     
==========================================
  Files          78       78              
  Lines        4777     4775       -2     
  Branches      450      450              
==========================================
- Hits         4475     4464      -11     
- Misses        177      185       +8     
- Partials      125      126       +1     
Impacted Files Coverage Δ
src/NRedisStack/Graph/GraphCommands.cs 87.14% <100.00%> (-0.19%) ⬇️
src/NRedisStack/Graph/GraphCommandsAsync.cs 87.14% <100.00%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested a review from chayim June 27, 2023 07:51
@chayim
Copy link
Contributor

chayim commented Jun 27, 2023

Need to change the version for this...

@chayim chayim changed the title Change GRAPH.DELETE Returned Value to bool Update GRAPH.DELETE to return bool Jun 27, 2023
@chayim chayim changed the title Update GRAPH.DELETE to return bool Support GRAPH.DELETE returning boolean Jun 27, 2023
@shacharPash shacharPash merged commit dfb621d into master Jun 27, 2023
@shacharPash shacharPash deleted the fixGraphErrors branch June 27, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants