-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer development environment #169
Add devcontainer development environment #169
Conversation
I think it should also be added to CONTRIBUTING.md a basic explanation of how to use devcontainer to make it easier for people to contribute code. |
Good point, will add a section. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 94.03% 94.03%
=======================================
Files 82 82
Lines 5080 5080
Branches 479 479
=======================================
Hits 4777 4777
Misses 176 176
Partials 127 127 ☔ View full report in Codecov by Sentry. |
…ersions from CI pipeline.
Signed-off-by: haysch <[email protected]>
…aysch/NRedisStack into feature/introduce-devcontainer
Local tests are now working in VS Code, inside dev container, after the introduction of the skipping attribute. Wrote a short section in |
Hey @haysch, great job! |
@shacharPash great extension/explanation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Add devcontainer * Add test tasks for the different Redis versions. Specify default .NET solution. * Minor clarification by moving initialization to constructor * Update devcontainer setup, and vscode tasks, to match updated Redis versions from CI pipeline. * Include section on DevContainers * Include section on DevContainers Signed-off-by: haysch <[email protected]> * Fix "spelling mistakes" * add explenation about dev containers * wordlist --------- Signed-off-by: haysch <[email protected]> Co-authored-by: shacharPash <[email protected]> Co-authored-by: shacharPash <[email protected]>
Based on issue #165 .
This PR adds support for devcontainer development environment in order to lower the barrier of entry to
NRedisStack
.