Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer development environment #169

Merged
merged 14 commits into from
Aug 21, 2023

Conversation

haysch
Copy link
Contributor

@haysch haysch commented Aug 10, 2023

Based on issue #165 .

This PR adds support for devcontainer development environment in order to lower the barrier of entry to NRedisStack.

@shacharPash
Copy link
Contributor

I think it should also be added to CONTRIBUTING.md a basic explanation of how to use devcontainer to make it easier for people to contribute code.

@haysch
Copy link
Contributor Author

haysch commented Aug 14, 2023

Good point, will add a section.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (80ec286) 94.03% compared to head (1e64e80) 94.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          82       82           
  Lines        5080     5080           
  Branches      479      479           
=======================================
  Hits         4777     4777           
  Misses        176      176           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haysch
Copy link
Contributor Author

haysch commented Aug 19, 2023

Local tests are now working in VS Code, inside dev container, after the introduction of the skipping attribute.

Wrote a short section in CONTRIBUTING.md, please let me know if you think anything is missing!

@shacharPash
Copy link
Contributor

shacharPash commented Aug 21, 2023

Hey @haysch, great job!
I added a more practical explanation about the use of dev containers.
What do you think?
And if there are inaccuracies or something wrong, you are welcome to correct/improve

@haysch
Copy link
Contributor Author

haysch commented Aug 21, 2023

@shacharPash great extension/explanation!
I don't have anything more to add - hopefully someone will find it as useful as I have!

Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shacharPash shacharPash added documentation Improvements or additions to documentation maintenance feature labels Aug 21, 2023
@shacharPash shacharPash merged commit 1c345ad into redis:master Aug 21, 2023
@haysch haysch deleted the feature/introduce-devcontainer branch August 21, 2023 13:39
shacharPash added a commit that referenced this pull request Aug 22, 2023
* Add devcontainer

* Add test tasks for the different Redis versions. Specify default .NET solution.

* Minor clarification by moving initialization to constructor

* Update devcontainer setup, and vscode tasks, to match updated Redis versions from CI pipeline.

* Include section on DevContainers

* Include section on DevContainers

Signed-off-by: haysch <[email protected]>

* Fix "spelling mistakes"

* add explenation about dev containers

* wordlist

---------

Signed-off-by: haysch <[email protected]>
Co-authored-by: shacharPash <[email protected]>
Co-authored-by: shacharPash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants