Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SORTABLE to the end of the build command #176

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Move SORTABLE to the end of the build command #176

merged 2 commits into from
Aug 20, 2023

Conversation

shacharPash
Copy link
Contributor

Closes #175

@shacharPash shacharPash added the bug Something isn't working label Aug 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (80ec286) 94.03% compared to head (d2614be) 94.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          82       82           
  Lines        5080     5080           
  Branches      479      479           
=======================================
  Hits         4777     4777           
  Misses        176      176           
  Partials      127      127
Files Changed Coverage Δ
src/NRedisStack/Search/Schema.cs 95.65% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

haysch
haysch reviewed Aug 20, 2023
View reviewed changes
Copy link
Contributor

@haysch haysch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things, but otherwise as expected

@shacharPash shacharPash requested review from haysch and a team and removed request for haysch August 20, 2023 12:57
@shacharPash shacharPash mentioned this pull request Aug 20, 2023
Closed
@shacharPash shacharPash merged commit c99124b into master Aug 20, 2023
@shacharPash shacharPash deleted the Issue175/Sortable branch August 20, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

@haysch haysch haysch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating JSON Index with sortable TagField throws exception
4 participants
@shacharPash @codecov-commenter @sazzad16 @haysch