Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check to Json.Get<T> #199

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

shacharPash
Copy link
Contributor

Closes #198

@shacharPash shacharPash added the bug Something isn't working label Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e32b6b6) 94.05% compared to head (839fce1) 94.12%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   94.05%   94.12%   +0.07%     
==========================================
  Files          85       85              
  Lines        5178     5178              
  Branches      488      488              
==========================================
+ Hits         4870     4874       +4     
+ Misses        181      177       -4     
  Partials      127      127              
Files Coverage Δ
src/NRedisStack/Json/JsonCommands.cs 89.65% <0.00%> (+1.37%) ⬆️
src/NRedisStack/Json/JsonCommandsAsync.cs 89.65% <0.00%> (+1.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash shacharPash requested review from chayim, slorello89 and a team October 25, 2023 12:28
Copy link
Member

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shacharPash shacharPash merged commit 954992e into master Oct 25, 2023
@shacharPash shacharPash deleted the Issue198/JsonGetExeption branch October 25, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonCommandsAsync.GetAsync<T> throws JsonException when not found.
3 participants