Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LATEST arg support for TS.MRANGE #236

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Conversation

atmuccio
Copy link
Contributor

@atmuccio atmuccio commented Jan 3, 2024

Removing null check that was already being performed by helper method.

Fixed LATEST argument not working in TS.MRANGE command calls.

Removing null check that was already being performed by helper method.

Fixed LATEST argument not working in TS.MRANGE command calls.
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbbfaae) 94.10% compared to head (93eae12) 94.10%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files          85       85           
  Lines        5178     5178           
  Branches      488      487    -1     
=======================================
  Hits         4873     4873           
  Misses        178      178           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash
Copy link
Contributor

Hi @atmuccio, thanks for your contribution!
LGTM 👍
Can you add a test to TestMRange to check that the LATEST works as expected?

@atmuccio
Copy link
Contributor Author

atmuccio commented Jan 8, 2024

Sure can, I'll get that added.

Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shacharPash shacharPash merged commit b725b9e into redis:master Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants