Fix dotnet version testing #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 94.10% 94.16% +0.05%
==========================================
Files 85 85
Lines 5178 5178
Branches 487 487
==========================================
+ Hits 4873 4876 +3
Misses 178 178
+ Partials 127 124 -3 ☔ View full report in Codecov by Sentry. |
gerzse
force-pushed
the
fix-ci-wrt-dotnet-versions
branch
2 times, most recently
from
1b7d486 to
832333c
Compare
gerzse
force-pushed
the
fix-ci-wrt-dotnet-versions
branch
10 times, most recently
from
64d6199 to
06a3ceb
Compare
Add net8.0 as target framework. Remove the `doctests` workflow, since all tests inside `tests/Doc` are executed anyway during the `integration` workflow. Separate the concurrency groups between workflows, to avoid them cancelling each other during one CI run. This seems to be a known issue: https://github.com/orgs/community/discussions/41518 Update the release workflow to use dotnet 8, given that we have it as a target now. Print the dotnet version and available SDKs and runtimes in some workflows, for clarity. Update the `reusable` workflow to build for a specific target framework, and to use a specific version of the dotnet SDK when building and running tests. This is done via a generated `global.json` file. The goal is to ensure that the source code can compile on all supported SDKs. Make the `linter` workflow do the checkout just like the others, without explicitly specifying what to checkout. Double the connection multiplexer timeout in tests, to avoid some tests failing (Gears related tests) occasionally.
gerzse
force-pushed
the
fix-ci-wrt-dotnet-versions
branch
from
06a3ceb to
e87eb2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure at each run in CI only the strictly needed dotnet version gets installed. Also target the code towards net8.0 too.
closes #227