Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test binary package in CI #252

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Feb 14, 2024

Issue #195

In the integration workflows, publish the binary package into a local Nuget source and use it as a binary, to make sure it works that way.

@gerzse gerzse requested a review from shacharPash February 14, 2024 16:05
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.27%. Comparing base (db17b89) to head (2069211).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          87       87           
  Lines        5367     5367           
  Branches      503      503           
=======================================
  Hits         5060     5060           
  Misses        181      181           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerzse gerzse force-pushed the test-binary-package branch 12 times, most recently from 5548b7a to 0a99789 Compare February 14, 2024 17:08
@gerzse gerzse force-pushed the test-binary-package branch from 0a99789 to 2069211 Compare February 23, 2024 14:15
@gerzse gerzse force-pushed the test-binary-package branch from 4a54c4b to 4e1da8a Compare March 4, 2024 15:13
Issue redis#195

In the integration workflows, publish the binary package into a local
Nuget source and use it as a binary, to make sure it works that way.
@gerzse gerzse force-pushed the test-binary-package branch from 4e1da8a to 6ebc68a Compare March 4, 2024 15:17
Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shacharPash shacharPash merged commit 4e21377 into redis:master Mar 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants