Add more blocking commands #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 94.12% 94.22% +0.09%
==========================================
Files 87 87
Lines 5279 5370 +91
Branches 496 503 +7
==========================================
+ Hits 4969 5060 +91
- Misses 183 184 +1
+ Partials 127 126 -1 ☔ View full report in Codecov by Sentry. |
The current naming for the blocking commands does not feel right. For example "BzmPop", it feels like there are no naming rules. So rename existing methods by this rule: Use capital letters at the beginning of human-readable words, e.g. "Pop", and also use capital letters where the Redis command has a single letter, e.g. "B", which stands for "Blocking", "Z" which stands for "Set" and "M" which stands for "Multi". So the new name is "BZMPop". It's still a good time to do such renaming, because these commands have not been released. Also it is a crucial moment to get the naming as right as possible, for the same reason.
gerzse
force-pushed
the
add-more-blocking-commands
branch
from
aff2277 to
c6ccaf0
Compare
shacharPash
reviewed
Feb 19, 2024
| [SkipIfRedis(Is.OSSCluster, Comparison.LessThan, "7.0.0")] | ||
| public void TestBLMPop() | ||
| { | ||
| var redis = ConnectionMultiplexer.Connect("localhost"); |
There was a problem hiding this comment.
We should use redisFixture.Redis instead of this (applies to all tests)
There was a problem hiding this comment.
True. I updated to use the fixture everywhere in CoreTests.
shacharPash
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for BLPOP, BRPOP, BLMPOP.