Load Redis test endpoints from config file or env vars #294
Conversation
uglide
changed the title
|
|
||
| redisEndpoints = parsedEndpoints ?? throw new Exception("Failed to parse the Redis endpoints configuration."); | ||
| } | ||
| else |
There was a problem hiding this comment.
Just an idea, would it work to have a default JSON file to load, so we don't do any config from code?
There was a problem hiding this comment.
Yes, we can replace it with a default JSON file. I did it only to keep it backward compatible with the existing GitHub workflows.
| configurationOptions.Password = password; | ||
| } | ||
|
|
||
| // TODO(imalinovskiy): Add support for TLS |
There was a problem hiding this comment.
Can we perhaps list somewhere the environments we would like to have?
I think the existing tests (which make sense to us) are a good reference as to what we need.
Everybody can suggest additions / deletions to this list
There was a problem hiding this comment.
The list of required environments depends on the current test coverage. For example, in Jedis, we need a huge list of Redis endpoints https://github.com/redis/jedis/pull/3836/files#diff-c731b96d111ab92ab2f88dcbe2e36abef53c269a71f96598463e6cc3b70b7acd and it doesn't yet cover the Sentinel and Cluster endpoints. As a first stage, I suggest identifying those endpoints and collecting them in endpoints.json file in each repo.
There was a problem hiding this comment.
Yes, this is what I meant, gather a list so we know what we need. Thanks!
No description provided.