Add bloom (BF) commands #3
Conversation
| } | ||
|
|
||
| public bool Exists(RedisKey key, string item) | ||
| public bool Exists(RedisKey key, RedisValue item) | ||
| { | ||
| return _db.Execute(BF.EXISTS, key, item).ToString() == "1"; |
There was a problem hiding this comment.
What happens when this fails and an exception is raised (if the module isn't present, for example).
There was a problem hiding this comment.
It will return false.
What would you expect to happen?
|
|
||
| List<object> args = new List<object> { key }; | ||
|
|
||
| foreach (var item in items) |
There was a problem hiding this comment.
Any reason you can't concat these two types of lists, rather than loop? Is it possible to do a:
args.Concat(items).ToList
There was a problem hiding this comment.
"Concat" and "AddRange" only works for Enumerable, and RedisValue[] is not Enumerable (it's also not working for input of type List<RedisValue>).
I haven't found a more elegant way than this..
I can Change it to:items.ForEach(item => args.Add(item));
Tell me if it's better in your opinion
|
|
||
| List<object> args = new List<object> { key }; | ||
|
|
||
| foreach (var item in items) |
There was a problem hiding this comment.
Same answer re: concat ;)
@chayim