Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAE-827] Changed ft create vector types to union, added support for int8/uint8 #2911

Merged
merged 2 commits into from
Mar 21, 2025
Merged

[CAE-827] Changed ft create vector types to union, added support for int8/uint8 #2911

merged 2 commits into from
Mar 21, 2025

Conversation

htemelski
Copy link
Collaborator

@htemelski htemelski commented Mar 21, 2025 •
edited
Loading

Description

Changed the vector type field from string to union with all supported versions (including int8 and uint8)

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@htemelski htemelski requested a review from bobymicroby March 21, 2025 08:28
bobymicroby
bobymicroby approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@htemelski htemelski merged commit d64072d into master Mar 21, 2025
11 checks passed
@htemelski htemelski deleted the cae-827 branch March 21, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobymicroby bobymicroby bobymicroby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htemelski @bobymicroby