Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix missing links in mapStateToProps.md #1467

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

anthonyc1
Copy link
Contributor

@anthonyc1 anthonyc1 commented Nov 21, 2019

In line 95, I added the correct title and link to the Factory Functions section of the connect() API page.

In line 105, I updated the link title to be more accurate, and added the actual hyperlink with the relevant information (if you go to the URL, you will see what I mean).

Edit: Also fixed missing link in line 142.

Verified

This commit was signed with the committer’s verified signature.
fmease León Orell Valerian Liehr
@netlify
Copy link

netlify bot commented Nov 21, 2019

Deploy preview for react-redux-docs ready!

Built with commit 808d1e7

https://deploy-preview-1467--react-redux-docs.netlify.com

@markerikson
Copy link
Contributor

Thanks, appreciate the PR. Can you change the docs link to be a relative path to the correct Markdown file instead?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@anthonyc1
Copy link
Contributor Author

@markerikson Added the relative link where applicable. The other non-relative links (fixed another missing link) point to the Redux documentation, not React-Redux docs.

@markerikson
Copy link
Contributor

Heh, right. Thanks!

@markerikson markerikson merged commit 1186016 into reduxjs:master Nov 22, 2019
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* docs: Fix missing links in mapStateToProps.md

* Address PR comment and fix additional missing link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants