#1944 converting test suite from Mocha to Jest #1951
Conversation
While looking into reduxjs#1944 I noticed that the examples in the documentation still uses expect's createSpy() instead of Jest's fn() approach
Added Jest dependencies Removed expect from files Updated mocks to use `jest.fn()` Current `expect.spyOn` replacement can be improved on TODO: Fix linter not to complain about using `console`
| @@ -304,7 +304,7 @@ import Header from '../../components/Header' | |||
|
|
|||
| function setup() { | |||
| const props = { | |||
| addTodo: expect.createSpy() | |||
| addTodo: jest.fn(() => {}) | |||
There was a problem hiding this comment.
Could be wrong but I think
addTodo: jest.fn()
is sufficient for a noop.
There was a problem hiding this comment.
@Florian-R indeed, according to the documentation that should work.
But weirdly, when I run jest with a no-args jest.fn() in applyMiddleware.spec.js I get the following error which, to me, seems totally unrelated:
FAIL test/applyMiddleware.spec.js
● Test suite failed to run
/Users/heinrichfilter/dev/src/redux/test/applyMiddleware.spec.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import { createStore, applyMiddleware } from '../src/index';
^^^^^^
SyntaxError: Unexpected token import
at transformAndBuildScript (../../../.nvm/v6.5.0/lib/node_modules/jest/node_modules/jest-runtime/build/transform.js:284:10)
I'm a bit confused by it and thought I'd leave it in until someone more knowledgeable can provide a definite answer.
Maybe someone else can run the tests and see if it gives get the same error?
There was a problem hiding this comment.
Yeah I give this issue a quick try too and noticed this kind of errors (my branch is roughly the same than yours). Didn't had much time to dig further though.
There was a problem hiding this comment.
@HeinrichFilter Played with your branch a bit, you might want to change your package.json scripts to
"test": "cross-env BABEL_ENV=commonjs jest",
otherwise you wont use the transform-es2015-modules-commonjs plugin.
Also, make sure to clear Jest cache on first launch, e.g.
npm run test -- --no-cache
Having just jest.fn() seems OK with this setup.
|
@Florian-R Thanks for the suggestions. I made the changes and updated the PR |
| @@ -105,6 +106,7 @@ | |||
| "gitbook-cli": "^2.3.0", | |||
| "glob": "^6.0.4", | |||
| "isparta": "^4.0.0", | |||
| "jest": "^15.1.1", | |||
| "mocha": "^2.2.5", | |||
There was a problem hiding this comment.
I guess we can remove mocha, expect and isparta from the package.json now.
There was a problem hiding this comment.
Thanks @ellbee
I removed the dependencies from package.json and updated test:cov to use jest
Updated test:cov command to use jest's --coverage option
| @@ -2,7 +2,7 @@ import * as tt from 'typescript-definition-tester' | |||
|
|
|||
|
|
|||
| describe('TypeScript definitions', function () { | |||
| this.timeout(0) | |||
| //this.timeout(0) | |||
There was a problem hiding this comment.
According to the Mocha homepage:
Use
this.timeout(0)to disable timeouts all together
On Travis (and my machine) the new Jest test passes without hitting the default timeout. Thus, in my opinion, the line should be removed.
But if I'm missing anything, let me know.
|
Thanks! |
* Fix Jest spy code in documentation While looking into reduxjs#1944 I noticed that the examples in the documentation still uses expect's createSpy() instead of Jest's fn() approach * reduxjs#1944 Converting tests from Mocha to Jest Added Jest dependencies Removed expect from files Updated mocks to use `jest.fn()` Current `expect.spyOn` replacement can be improved on TODO: Fix linter not to complain about using `console` * Disable eslint no-console for console related tests * Made changes suggested by @Florian-R that enable no-args jest.fn() calls https://github.com/reactjs/redux/pull/1951/files/927bf45f1c7666e42ae8c4c390cc726a75cab903#r78733124 * Removed moch, expect and isparta Updated test:cov command to use jest's --coverage option * Update typescript.spec.js
Just wanted to get something going where the tests are passing on my machine.
The replacement for
expect.spyOn()is not ideal. It is quite verbose and the linter doesn't like thatconsoleis accessed. It might make sense to use jestjs/jest#1592 (comment) when it becomes available.Please let me know what else I can do.